Fix materialized view failure mode when base table gone#15929
Merged
findepi merged 2 commits intotrinodb:masterfrom Feb 2, 2023
Conversation
findepi
requested review from
alexjo2144,
anjalinorwood,
ebyhr,
electrum,
findinpath and
losipiuk
alexjo2144
approved these changes
Feb 1, 2023
Member
Author
findepi
force-pushed
the
findepi/avoid-failing-materialized-view-operations-when-base-table-gone-a1d974
branch
from
17207ba to
6deb2b6
Compare
ebyhr
approved these changes
Feb 1, 2023
findinpath
approved these changes
Feb 2, 2023
Contributor
There was a problem hiding this comment.
snapshotAtRefresh seems too specialized in the scope of this method.
Member
Author
There was a problem hiding this comment.
not sure what you would suggest here?
Contributor
There was a problem hiding this comment.
snapshotAtRefresh -> snapshotId
Member
Author
There was a problem hiding this comment.
ok, and will also rename to isSnapshotCurrent
Member
Author
This is just a refactor - Inline `getTableToken` - Remove redundant `TableToken` (it is not used for populating DEPENDS_ON_TABLES field, so doesn't provide any encapsulation) - reduce visibility - remove redundant cast & conversions - move below the usage, as it is a helper - give the method a better name.
Reporting `MaterializedViewNotFoundException` for a freshness check resulted in `SELECT .. FROM mv` query failing in "materialized view mv does not exist", which was not correct, since it exists, just cannot be queried.
findepi
force-pushed
the
findepi/avoid-failing-materialized-view-operations-when-base-table-gone-a1d974
branch
from
6deb2b6 to
387a9f0
Compare
findepi
deleted the
findepi/avoid-failing-materialized-view-operations-when-base-table-gone-a1d974
branch
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #15842